[Merged by Bors] - Relax mutability requirements of FluvioAdmin client #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehz
requested changes
Jun 18, 2021
|
I believe this is totally backwards compatible. Passing a let mut admin = fluvio.admin().await; // Warning: `admin` does not need to be mutable
admin.list::<TopicSpec>(vec![]).await?; |
|
Let me see how hard it's going to be to fix clippy (new lints from 1.53) |
|
Can you put 1.53 clippy fix as separate PR? |
nicholastmosher
force-pushed
the
admin-tweaks
branch
from
a37d060
to
e8a838e
Compare
morenol
approved these changes
Jun 18, 2021
nicholastmosher
force-pushed
the
admin-tweaks
branch
from
e8a838e
to
a6f59db
Compare
nicholastmosher
force-pushed
the
admin-tweaks
branch
from
a6f59db
to
7d895c2
Compare
|
Should pass now that clippy fixes are merged. bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 18, 2021
Closes #1178. Will help to prevent bugs like infinyon/fluvio-client-wasm#42 - Changes `&mut self` to `&self` for `create`, `delete`, and `list` methods on `FluvioAdmin`.
|
Timed out. |
|
Dang, I think something wonky happened with the macos job and caused it to take a really long time. Let's see if that was a fluke. The workflow was like 2 minutes from being done when Bors timed out 😭 bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 18, 2021
Closes #1178. Will help to prevent bugs like infinyon/fluvio-client-wasm#42 - Changes `&mut self` to `&self` for `create`, `delete`, and `list` methods on `FluvioAdmin`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1178. Will help to prevent bugs like infinyon/fluvio-client-wasm#42
&mut selfto&selfforcreate,delete, andlistmethods onFluvioAdmin.