Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Defer stream initialization in consumer #1456

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Defer stream initialization in consumer #1456

wants to merge 1 commit into from

Conversation

morenol
Copy link
Contributor

@morenol morenol commented Aug 18, 2021

Fixes #986

@morenol morenol changed the title Do not wait for first record on stream creation Defer stream initialization Aug 18, 2021
@morenol morenol changed the title Defer stream initialization Defer stream initialization in consumer Aug 18, 2021
@morenol morenol requested a review from sehz August 18, 2021 22:42
sehz
sehz approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sehz
Copy link
Contributor

sehz commented Aug 18, 2021

bors r+

bors bot pushed a commit that referenced this pull request Aug 18, 2021
@morenol
Defer stream initialization in consumer (#1456)
fd43b19 
Fixes #986
@bors
Copy link

bors bot commented Aug 18, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Defer stream initialization in consumer [Merged by Bors] - Defer stream initialization in consumer Aug 18, 2021
@bors bors bot closed this Aug 18, 2021
@morenol morenol deleted the lmm/consumer branch August 19, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PartitionConsumer::stream should not block while there are no records
2 participants
@morenol @sehz