[Merged by Bors] - Add progress bar to cluster local setup #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morenol
force-pushed
the
lmm/local-setup-progress
branch
3 times, most recently
from
6d47e03
to
0907769
Compare
morenol
force-pushed
the
lmm/local-setup-progress
branch
from
0907769
to
41da8fa
Compare
Trait for rendered text Stop loop in case of failure Add spinner to progress bar Update changelog
morenol
force-pushed
the
lmm/local-setup-progress
branch
from
05a8681
to
e265b8e
Compare
|
Still reviewing, but right off the bat I'm seeing warnings for unused Results. |
Comment on lines
+426
to
+432
| let mut progress = cluster_checker | ||
| .run_and_fix_with_progress() | ||
| .map(|check| Ok(LocalSetupProgressMessage::Check(check))); | ||
| sender | ||
| .send_all(&mut progress) | ||
| .await | ||
| .map_err(LocalInstallError::ChannelSendError)?; |
There was a problem hiding this comment.
The key difference is here. progress is a stream and sender is a sink, so we can plug them together with send_all instead of needing to loop to push events through
nicholastmosher
approved these changes
Sep 9, 2021
morenol
force-pushed
the
lmm/local-setup-progress
branch
from
fdcb197
to
7530f31
Compare
morenol
force-pushed
the
lmm/local-setup-progress
branch
from
7530f31
to
f95515d
Compare
|
bors r + |
|
bors ping |
|
pong |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 10, 2021
Update to progress indicator for this command: `fluvio cluster start --local --setup` Co-authored-by: Nick Mosher <nicholastmosher@gmail.com>
1 task
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to progress indicator for this command:
fluvio cluster start --local --setup