[Merged by Bors] - Fix index corruption #2186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change OffsetOutOfRange to Other for more details
sehz
force-pushed
the
fix_index_corruption
branch
from
39fdf50
to
d63116c
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 15, 2022
resolves #2116. * Fix soundness of the batch offset_delta. Update tests to fully specify behavior. * Add internal CLI too to validate the segment. This can be invoked by: ```cargo run --bin storage-cli --features=cli --release```. * Change default `StorageBytesIterator` implementation to use `pread` call instead of the memory map. It is 10x slower but should reduce I/O overhead. * Instead of using async-fil write, use `std` file system write to avoid `reposition` call which could batch to be overwritten in high overload case. This could incur some latency due to the fact `write` is not async. This should be resolved once we have the next generation of the file i/o sub-system. * Improve index write logic to improve efficiency. Before it was writing index offset too much.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2116.
cargo run --bin storage-cli --features=cli --release.StorageBytesIteratorimplementation to usepreadcall instead of the memory map. It is 10x slower but should reduce I/O overhead.stdfile system write to avoidrepositioncall which could batch to be overwritten in high overload case. This could incur some latency due to the factwriteis not async. This should be resolved once we have the next generation of the file i/o sub-system.