Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: check for Smart.toml file to be present in cwd #2739

Conversation

EstebanBorai
Copy link
Contributor

@EstebanBorai EstebanBorai commented Oct 22, 2022

Checks for the SmartModule.toml file to be present in the CWD when running smdk generate command.

➜  smdk publish
Error: No "SmartModule.toml" file found

➜  touch SmartModule.toml
➜  smdk publish
Error: missing field `package`

Resolves: #2678

Checks for the `SmartModule.toml` file to be present in the CWD when
running `smdk generate` command.

```bash
➜  smdk publish
Error: No "SmartModule.toml" file found

➜  touch SmartModule.toml
➜  smdk publish
Error: missing field `package`
```

Resolves: infinyon#2678
@EstebanBorai EstebanBorai force-pushed the fix/smdk-publish-resolve-cargo-toml branch from 1589b8a to e3ff232 Compare October 22, 2022 14:45
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, I'd add TJ as a reviewer.

@digikata digikata requested a review from tjtelan October 31, 2022 17:26
Copy link
Contributor

@tjtelan tjtelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are straightforward and overall less code. Lgtm!

@EstebanBorai
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Nov 4, 2022
Checks for the `SmartModule.toml` file to be present in the CWD when running `smdk generate` command.

```bash
➜  smdk publish
Error: No "SmartModule.toml" file found

➜  touch SmartModule.toml
➜  smdk publish
Error: missing field `package`
```

Resolves: #2678
@bors
Copy link

bors bot commented Nov 4, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: check for Smart.toml file to be present in cwd [Merged by Bors] - feat: check for Smart.toml file to be present in cwd Nov 4, 2022
@bors bors bot closed this Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve SmartModule.toml resolution
3 participants