Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix: Enabled --file and --key-separator to be used together, fix --key handling when producing lines #3092

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - fix: Enabled --file and --key-separator to be used together, fix --key handling when producing lines #3092

wants to merge 9 commits into from

Conversation

ozgrakkurt
Copy link
Contributor

@ozgrakkurt ozgrakkurt commented Mar 22, 2023 •
edited

closes #3076

The issue also mentions it should be added to the CI. I'm looking into doing that.

DISCLAIMER: I didn't test this yet

@ozgrakkurt ozgrakkurt changed the title Enable --file and --key-separator to be used together, handle --key when reading lines from file Enable --file and --key-separator to be used together, fix --key handling when producing lines Mar 22, 2023
@ozgrakkurt ozgrakkurt changed the title Enable --file and --key-separator to be used together, fix --key handling when producing lines fix: Enabled --file and --key-separator to be used together, fix --key handling when producing lines Mar 22, 2023
@sehz sehz requested a review from EstebanBorai March 23, 2023 15:52
@ozgrakkurt
Copy link
Contributor Author

Added test

@ozgrakkurt
Copy link
Contributor Author

ozgrakkurt commented Mar 23, 2023 •
edited

It seems like this is failing because of something with CI, is it not rebuilding the cli?

nevermind I see the point

@EstebanBorai
Copy link
Contributor

It seems like this is failing because of something with CI, is it not rebuilding the cli?

nevermind I see the point

Hi @ozgrakkurt! Good work so far!

Looks like the issue is here: https://github.com/infinyon/fluvio/actions/runs/4504419808/jobs/7929176514?pr=3092#step:16:72

Due to conflicts with arguments passed on test.

@ozgrakkurt
Copy link
Contributor Author

Hey @EstebanBorai,

Old version fails with those options and part of the PR was making it so that it accepts those options.

So the test I added fails with old version but passes with new version.

Not sure how to integrate this with the test.

@sehz
Copy link
Contributor

sehz commented Mar 24, 2023

In that case, run that particular test on new version

@ozgrakkurt
Copy link
Contributor Author

@sehz I added some hack to do this in the last commit. What would be a proper way of doing this?

@sehz
Copy link
Contributor

sehz commented Mar 24, 2023

That's reasonable fix!

EstebanBorai
EstebanBorai approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@EstebanBorai EstebanBorai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work @ozgrakkurt!

@EstebanBorai
Copy link
Contributor

@ozgrakkurt smart way to tune tests for this use case!

@ozgrakkurt
Copy link
Contributor Author

@EstebanBorai thanks!

morenol
morenol reviewed Mar 24, 2023
View reviewed changes
tests/cli/fluvio_smoke_tests/e2e-file-with-separator.bats
Comment on lines +48 to +50
if [ "$FLUVIO_CLI_RELEASE_CHANNEL" == "stable" ]; then
skip "don't run on stable version"
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice trick!

We should create an issue to update this once we release a new stable version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ozgrakkurt
Copy link
Contributor Author

Hey @sehz, can you check when you have time?

@EstebanBorai
Copy link
Contributor

bors r+

bors bot pushed a commit that referenced this pull request Mar 25, 2023
@ozgrakkurt
fix: Enabled --file and --key-separator to be used together, fix …
90b6a4e 
…`--key` handling when producing lines (#3092)

closes #3076

The issue also mentions it should be added to the CI. I'm looking into doing that.

DISCLAIMER: I didn't test this yet

Co-authored-by: Özgür Akkurt <91746947+ozgrakkurt@users.noreply.github.com>
@bors
Copy link

bors bot commented Mar 25, 2023

Build failed:

@sehz
Copy link
Contributor

sehz commented Mar 25, 2023

bors r+

bors bot pushed a commit that referenced this pull request Mar 25, 2023
@ozgrakkurt
fix: Enabled --file and --key-separator to be used together, fix …
6263076 
…`--key` handling when producing lines (#3092)

closes #3076

The issue also mentions it should be added to the CI. I'm looking into doing that.

DISCLAIMER: I didn't test this yet

Co-authored-by: Özgür Akkurt <91746947+ozgrakkurt@users.noreply.github.com>
@bors
Copy link

bors bot commented Mar 25, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix: Enabled --file and --key-separator to be used together, fix --key handling when producing lines [Merged by Bors] - fix: Enabled --file and --key-separator to be used together, fix --key handling when producing lines Mar 25, 2023
@bors bors bot closed this Mar 25, 2023
This was referenced Mar 27, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz approved these changes

@morenol morenol morenol approved these changes

@EstebanBorai EstebanBorai EstebanBorai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fluvio produce options --key-separator and --file should not be mutually exclusive
4 participants
@ozgrakkurt @EstebanBorai @sehz @morenol