Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disallow deletion system topic unless forced #3942

Merged

Conversation

galibey
Copy link
Contributor

@galibey galibey commented Apr 10, 2024

If user tries to delete a system topic:

$ fluvio topic delete consumer-offset
system topic 'consumer-offset' can only be deleted forcibly

with the --system argument:

$ fluvio topic delete consumer-offset --system
You are trying to delete a system topic 'consumer-offset'. It can affect the functioning of the cluster.

Are you sure you want to proceed? (y/n)
y
system topic "consumer-offset" deleted

with --system and --force:

$ fluvio topic delete consumer-offset --system --force
system topic "consumer-offset" deleted

@galibey galibey self-assigned this Apr 10, 2024
@galibey galibey added the CLI label Apr 10, 2024
@ajhunyady
Copy link
Contributor

Nice job @galibey! Looks good from the usability perspective.

Copy link
Contributor

@ajhunyady ajhunyady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usability looks good (I did not review the code).

Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good except issue about delete API

crates/fluvio/src/admin.rs Show resolved Hide resolved
@galibey galibey force-pushed the feat/forbid-deletion-of-system-topic branch from caa24f2 to 15ea6d8 Compare April 11, 2024 06:23
@galibey galibey added this pull request to the merge queue Apr 11, 2024
Merged via the queue into infinyon:master with commit 06450c8 Apr 11, 2024
104 checks passed
@galibey galibey deleted the feat/forbid-deletion-of-system-topic branch April 11, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants