Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk): generate command params #4026

Merged
merged 10 commits into from
Jun 15, 2024
Merged

Conversation

EstebanBorai
Copy link
Contributor

@EstebanBorai EstebanBorai commented May 24, 2024

Provides params on CDK CLI generation command to be executed in not I/O environments, similar to how SMDK does.

This allow to run CDK's generate command for testing environments where interactive I/O
is not supported.

As part of this PR tests on the same command are also introduced, which ensures the integrity of the generated project for Sink and Source connectors.

For reference in SMDK:

# Generate
run $SMDK_BIN generate \
$PARAMS_FLAG \
$SM_CRATE_PATH_FLAG \
$TESTING_GROUP_NAME_FLAG \
--sm-type $SMDK_SM_TYPE \
--sm-public $SMDK_SM_PUBLIC \
--silent \
$SM_PACKAGE_NAME
assert_success

@EstebanBorai EstebanBorai linked an issue May 24, 2024 that may be closed by this pull request
@EstebanBorai EstebanBorai marked this pull request as ready for review June 15, 2024 00:04
@sehz
Copy link
Contributor

sehz commented Jun 15, 2024

Can you add more description on what this does?

@EstebanBorai
Copy link
Contributor Author

Can you add more description on what this does?

Of course! I just updated the PR description.

@EstebanBorai EstebanBorai requested a review from sehz June 15, 2024 20:35
@EstebanBorai EstebanBorai added this pull request to the merge queue Jun 15, 2024
Merged via the queue into master with commit 95b43dc Jun 15, 2024
104 checks passed
@EstebanBorai EstebanBorai deleted the feat/cdk-generate-params branch June 15, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdk generate params and generated project integrity
2 participants