-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdk): generate command params #4026
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EstebanBorai
force-pushed
the
feat/cdk-generate-params
branch
from
May 24, 2024 21:27
af6cf49
to
d93c0b2
Compare
EstebanBorai
force-pushed
the
feat/cdk-generate-params
branch
from
May 24, 2024 21:50
d93c0b2
to
a5846e6
Compare
EstebanBorai
commented
Jun 15, 2024
Can you add more description on what this does? |
Of course! I just updated the PR description. |
sehz
reviewed
Jun 15, 2024
sehz
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides params on CDK CLI generation command to be executed in not I/O environments, similar to how SMDK does.
This allow to run CDK's
generate
command for testing environments where interactive I/Ois not supported.
As part of this PR tests on the same command are also introduced, which ensures the integrity of the generated project for Sink and Source connectors.
For reference in SMDK:
fluvio/tests/cli/smdk_smoke_tests/smdk-basic.bats
Lines 97 to 106 in ce2bcb5