Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: test mqtt connector #23

Closed
wants to merge 14 commits into from

Conversation

EstebanBorai
Copy link
Collaborator

@EstebanBorai EstebanBorai commented Apr 13, 2023

Test message consumption from MQTT using Cloud and Connectors

@EstebanBorai EstebanBorai linked an issue Apr 13, 2023 that may be closed by this pull request
@EstebanBorai EstebanBorai marked this pull request as ready for review April 17, 2023 03:01
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/e2e_cloud.yml Outdated Show resolved Hide resolved
@galibey
Copy link
Contributor

galibey commented Apr 18, 2023

Since this connector already has integration tests written in Rust, I would propose choosing this approach for Cloud integration tests as well. It will give us more stability (no static sleeps) and better maintainability.

@EstebanBorai
Copy link
Collaborator Author

Since this connector already has integration tests written in Rust, I would propose choosing this approach for Cloud integration tests as well. It will give us more stability (no static sleeps) and better maintainability.

I really like the idea of using only Rust but the goal with these is to perform tests against CLI just as the user will do.

@galibey
Copy link
Contributor

galibey commented Apr 18, 2023

Since this connector already has integration tests written in Rust, I would propose choosing this approach for Cloud integration tests as well. It will give us more stability (no static sleeps) and better maintainability.

I really like the idea of using only Rust but the goal with these is to perform tests against CLI just as the user will do.

Yes, and this all can be done by Rust. For instance -

let output = Command::new("cdk").arg("deploy").arg("list").output()?;

@sehz
Copy link
Contributor

sehz commented Apr 18, 2023

Since this connector already has integration tests written in Rust, I would propose choosing this approach for Cloud integration tests as well. It will give us more stability (no static sleeps) and better maintainability.

I really like the idea of using only Rust but the goal with these is to perform tests against CLI just as the user will do.

Yes, and this all can be done by Rust. For instance -

let output = Command::new("cdk").arg("deploy").arg("list").output()?;

While I agree rust based CLI test will be better, we dont have good tooling yet. Fluvio repo uses BATS still and should be ok to use until we have rust replacement. We should have issue to replace it and make progress on this

@EstebanBorai EstebanBorai requested a review from sehz April 18, 2023 16:34
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/e2e_cloud.yml Outdated Show resolved Hide resolved
@EstebanBorai EstebanBorai requested a review from sehz April 19, 2023 15:30
.github/workflows/e2e_cloud.yml Outdated Show resolved Hide resolved
@EstebanBorai EstebanBorai requested a review from sehz April 25, 2023 01:19
@EstebanBorai
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 25, 2023
Test message consumption from MQTT using Cloud and Connectors
@bors
Copy link

bors bot commented Apr 25, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title feat: test mqtt connector [Merged by Bors] - feat: test mqtt connector Apr 25, 2023
@bors bors bot closed this Apr 25, 2023
@bors bors bot deleted the 13-cloud-integration-tests branch April 25, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud Integration Tests
3 participants