[Merged by Bors] - Remove global initialization of logger

examples/Cargo.toml

@@ -18,4 +18,5 @@ members = [
     "bigint",
     "tuples",
     "uuid",
+    "logging",
 ]

examples/Makefile

@@ -14,10 +14,11 @@ clean:
 	make -C bigint clean
 	make -C tuple clean
 	make -C cleanup clean
+	make -C logging clean
 
 
 test: test-function test-cb test-async-cb test-promise test-json test-class-simple \
-	test-class-wrapper test-class-async test-stream test-buffer test-array test-bigint \
+	test-class-wrapper test-class-async test-stream test-buffer test-array test-bigint test-logging\
 	test-cleanup
 
 test-function:
@@ -65,6 +66,9 @@ test-bigint:
 test-tuple:
 	make -C tuple test
 
+test-logging:
+	make -C logging test
+
 test-cleanup:
 	make -C cleanup test
 

examples/logging/.gitignore

@@ -0,0 +1 @@
+dylib

examples/logging/Cargo.toml

@@ -0,0 +1,18 @@
+[package]
+name = "nj-example-logging"
+version = "0.1.0"
+authors = ["fluvio.io"]
+edition = "2018"
+
+
+[lib]
+crate-type = ["cdylib"]
+
+
+[dependencies]
+node-bindgen = { path = "../.."}
+log = "0.4"
+env_logger = "0.9"
+
+[build-dependencies]
+node-bindgen = { path = "../../", features = ["build"] }

examples/logging/Makefile

@@ -0,0 +1,10 @@
+all:	build
+
+build:
+	nj-cli build
+
+test:	build
+	RUST_LOG=info node test.js
+
+clean:
+	rm -rf dist

examples/logging/README.md

@@ -0,0 +1 @@
+simple hello world

examples/logging/build.rs

@@ -0,0 +1,3 @@
+fn main() {
+    node_bindgen::build::configure();
+}

examples/logging/src/lib.rs

@@ -0,0 +1,16 @@
+use node_bindgen::derive::node_bindgen;
+use node_bindgen::init::node_bindgen_init_once;
+use log::{info, warn};
+
+#[node_bindgen_init_once]
+fn init_logging() {
+    // initialize logging framework
+    env_logger::init();
+    info!("logging initialized");
+}
+
+#[node_bindgen()]
+fn hello(count: i32) -> String {
+    warn!("calling hello");
+    format!("hello world {}", count)
+}

examples/logging/test.js

@@ -0,0 +1,7 @@
+let addon = require('./dist');
+const assert = require('assert');
+
+assert.strictEqual(addon.hello(2), "hello world 2");
+
+
+console.log("logging tests succeed");

nj-core/src/lib.rs

@@ -28,6 +28,9 @@ use class::JSObjectWrapper;
 pub mod sys {
     pub use nj_sys::*;
 }
+pub mod init {
+    pub use ctor::ctor as node_bindgen_init_once;
+}
 
 pub mod future {
     pub use fluvio_future::task::spawn;
@@ -120,7 +123,3 @@ macro_rules! method {
         nj::core::Property::new($name).method($rs_method)
     }};
 }
-
-pub fn init_logger() {
-    fluvio_future::subscriber::init_logger();
-}

nj-core/src/module.rs

@@ -86,7 +86,6 @@ fn init_module() {
         ],
     };
 
-    crate::init_logger();
     unsafe {
         napi_module_register(&mut _MODULE);
     }

src/lib.rs

@@ -8,6 +8,11 @@ pub mod sys {
     pub use nj_sys::*;
 }
 
+#[cfg(feature = "node")]
+pub mod init {
+    pub use nj_core::init::*;
+}
+
 #[cfg(feature = "node")]
 pub mod derive {
     pub use nj_derive::*;