Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change behaviour of scrobbler to clear sent scrobbles when successful #105

Merged
merged 3 commits into from
Apr 27, 2018

Commits on Aug 24, 2017

  1. Add RemoveFromCache and GetCachedCount methods to IScrobbler and SQLi…

    …te implementation
    
    - change scrobbler behaviour to remove sucessfully scrobbled tracks from the cache
    - change return value of Scrobble methods - will always be either Successful, Cached. Actual failure reason may be stored by Scrobbler cache impl
    - Remove CacheEnabled property from IScrobbler. Just use new MemoryScrobbler class if needed
    - Remove Scrobbler class, add MemoryScrobbler. No migration path because the behaviour is different - and the old behaviour not that useful
    rikkit committed Aug 24, 2017
    Configuration menu
    Copy the full SHA
    f71140a View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2017

  1. Fix cached scrobbles not being removed from cache, accepted count on …

    …ScrobbleAsync.ScrobbleResponse not being set
    
    - Update tests data
    rikkit committed Sep 24, 2017
    Configuration menu
    Copy the full SHA
    5151de8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca1559b View commit details
    Browse the repository at this point in the history