Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sample stage #105

Merged
merged 1 commit into from
Oct 31, 2023
Merged

feat: add sample stage #105

merged 1 commit into from
Oct 31, 2023

Conversation

erie0210
Copy link
Contributor

@erie0210 erie0210 commented Oct 31, 2023 •
edited
Loading

resolves #71

@jbl428 jbl428 self-requested a review October 31, 2023 13:01
jbl428
jbl428 reviewed Oct 31, 2023
View reviewed changes
...test/kotlin/com/github/inflab/example/spring/data/mongodb/repository/SampleRepositoryTest.kt
val result = sampleRepository.example()

// then
result.mappedResults.toSet().size shouldBe 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use shouldHaveSize method too.

Suggested change
result.mappedResults.toSet().size shouldBe 3
result.mappedResults.toSet() shouldHaveSize 3

jbl428
jbl428 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@jbl428 jbl428 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution 👍

@jbl428 jbl428 merged commit 3444e78 into inflearn:main Oct 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbl428 jbl428 jbl428 approved these changes

Assignees

@erie0210 erie0210

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement $sample stage dsl
2 participants
@erie0210 @jbl428