Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/override identify by #15

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ryanbrunner
Copy link

Ability to override identify by. This will allow subscribers to specify a different set of fields to subscribe to.

@sachinsiby
Copy link
Contributor

@ryanbrunner So it looks like I can now specify a custom identifier on the subscriber / listener side. That's pretty useful, especially since in majority-report, we're frequently not using the incoming id column as majority-report's primary key.

include MultipleMan::Subscriber
subscribe fields: {
id: :id,
name: :remote_name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be remote_name: name? If the incoming is the key and the remapped name is the value.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya your docs suggest the hash format is {:from => :to}

which would yield {remote_name: :name}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants