-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If unable to connect to source host page always says "Loading Hosts..." #1003
Comments
@goller What should Chronograf do in this case? |
@cryptoquick I think it should only display loading hosts when it is running a query. If the query returns zero hosts, I think it should say zero hosts found. If it cannot contact the server (error or otherwise) it should say something about unable to connect, etc. |
Sounds good. I'll see what I can do. |
I got this error: the data as below: {
"results": [{
"statement_id": 0
}, {
"statement_id": 1
}, {
"statement_id": 2,
"series": [{
"name": "win_cpu",
"tags": {
"host": "MyServer"
},
"columns": ["time", "mean"],
"values": [
[1490658776937, 8.668630778541168]
]
}]
}, {
"statement_id": 3,
"series": [{
"name": "win_system",
"tags": {
"host": "MyServer"
},
"columns": ["time", "mean"],
"values": [
[1490659366939, 0]
]
}]
}, {
"statement_id": 4
}, {
"statement_id": 5
}]
} softwares: |
@games can you try making chronograf from the code that's in master? Or the latest release. |
@games thank you for the bug report! Especially, thank you for the results from the endpoint. @games @cryptoquick My hunch is that it is this query: show tag values from system with key = "host" that is used here: chronograf/ui/src/hosts/apis/index.js Line 20 in 2ee0008
@cryptoquick To fix this we need another query here: chronograf/ui/src/hosts/apis/index.js Line 8 in 2ee0008
The query would likely be show tag values from win_system with key = "host" Additionally, this piece of code needs an additional query: chronograf/ui/src/hosts/apis/index.js Line 70 in 2ee0008
The query would also likely be show tag values from win_system with key = "host" |
When failing to connect to a source, rather than showing an error message it says "Loading Hosts..."
The text was updated successfully, but these errors were encountered: