Bugfix/1003: Hosts Loading Messaging #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
121watts
approved these changes
Mar 27, 2017
| shape, | ||
| string, | ||
| } = PropTypes | ||
|
|
ui/src/hosts/containers/HostsPage.js
Outdated
| addFlashMessage({type: 'error', text: reason}) | ||
| this.setState({ | ||
| hostsError: reason.toString(), | ||
| hostsLoading: false, |
There was a problem hiding this comment.
I don't think you need the toString() here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect #1003
The problem
If there are zero hosts available, often this isn't a sign of an error, it just means there are actually zero hosts available. If there is an actual error, it was not displayed.
The Solution
Separate the branching conditions so hosts and errors are handled separately. Loading is handled separately as well.