Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove group by auto from Kapacitor alert rule builder #1730

Closed
jaredscheib opened this issue Jul 17, 2017 · 3 comments
Closed

Remove group by auto from Kapacitor alert rule builder #1730

jaredscheib opened this issue Jul 17, 2017 · 3 comments
Assignees

Comments

@jaredscheib
Copy link
Contributor

jaredscheib commented Jul 17, 2017

screen shot 2017-07-17 at 4 55 28 pm

@jaredscheib
Copy link
Contributor Author

screen shot 2017-07-20 at 3 19 22 pm

@jaredscheib
Copy link
Contributor Author

That error comes up and it's not clear what the problem is from the error message. But it's because auto is the default setting, and one would not think to turn off auto. Also, template variables aren't implemented for Kapacitor alert queries. So it makes creating an alert obscurely error out without any indication that it's due to auto unless you look at the console.

@jaredscheib
Copy link
Contributor Author

jaredscheib commented Jul 21, 2017

@nathanielc says there's no reason to have auto GROUP BY for Kapacitor alerts, and that it would be confusing.

I'll remove it.

@jaredscheib jaredscheib changed the title RFC: Remove group by auto from Kapacitor alert rule builder Remove group by auto from Kapacitor alert rule builder Jul 21, 2017
@jaredscheib jaredscheib self-assigned this Jul 21, 2017
@nhaugo nhaugo closed this as completed Jul 25, 2017
@nhaugo nhaugo removed the delivered label Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants