Prevent 'auto' GROUP BY option in Kapacitor rule builder #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect #1730
The problem
autowas appearing as an option (and the default option) in Kapacitor rule builder when a user would apply a function a field. This doesn't make sense and also would cause an unspecific error notification to the user (unless they looked at the console) when they tried to save their alert, if they had applied a function to a field and didn't change their GROUP BY away from the default option of 'auto', resulting in confusion and no insight into how to successfully save an alert.The Solution
Make
10sthe default option for Kapacitor rule builder function field GROUP BY dropdown, and prevent 'auto' from appearing.