Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hosts Page Apps Tag Parsing #2398

Merged
merged 4 commits into from Nov 28, 2017
Merged

Conversation

cryptoquick
Copy link
Contributor

@cryptoquick cryptoquick commented Nov 21, 2017

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

Connect #2255

The problem

The tag parseTag regex was written to parse out key/values, but sometimes tags come back from Influx without a value. This results in a null match, and kills Hosts Page Apps listing functionality.

The Solution

Add a null guard to tag parsing function to prevent parsing values that don't match tag RegEx.

@cryptoquick cryptoquick merged commit 2fb9196 into master Nov 28, 2017
@cryptoquick cryptoquick deleted the bugfix/hosts-page-error-2255 branch November 28, 2017 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants