Fix loading status description #4272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OfTheDelmer
force-pushed
the
fix/logs-loading-description
branch
from
6d4acd3
to
5e02bfb
Compare
mavarius
approved these changes
Aug 23, 2018
OfTheDelmer
added a commit
that referenced
this pull request
Sep 5, 2018
OfTheDelmer
added a commit
that referenced
this pull request
Sep 6, 2018
OfTheDelmer
added a commit
that referenced
this pull request
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
The loading description was not displaying after a search
What was the solution?
Fix randomLoadingDescription to be a getter and a space to no results description