Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): upgrade Go to 1.20.10 #6063

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Conversation

alespour
Copy link
Contributor

@alespour alespour commented Oct 12, 2023

Closes https://github.com/influxdata/edge/issues/509

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • Any changes to etc/Dockerfile_build have been pushed to DockerHub, and the changes have been added to .circleci/config.yml

Copy link
Contributor

@jdstrand jdstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Can you also pull in #6062 since it fixes the same http/2 issue in golang.org/x/net? Thanks!

@alespour
Copy link
Contributor Author

@jdstrand I've no idea how to satisfy checklist item Any changes to etc/Dockerfile_build have been pushed to DockerHub, and the changes have been added to .circleci/config.yml

@jdstrand
Copy link
Contributor

@jdstrand I've no idea how to satisfy checklist item Any changes to etc/Dockerfile_build have been pushed to DockerHub, and the changes have been added to .circleci/config.yml

@jeffreyssmith2nd or @bnpfeife - do you have details for this?

@jeffreyssmith2nd
Copy link
Contributor

That will happen as part of the next full release, so not something that needs to be worried about in this PR.

@jeffreyssmith2nd
Copy link
Contributor

Ah I'm sorry, misread this. The etc/Dockerfile_build is to pushed to a quay.io repository and has to be manually built locally and pushed. @alespour I will add some docs to this repo on how to do that and link them on this PR.

@jeffreyssmith2nd
Copy link
Contributor

Here's a PR with the docs: #6064

@jdstrand
Copy link
Contributor

That will happen as part of the next full release, so not something that needs to be worried about in this PR.

Fyi just for clarity, we do want to cut a new chronograf release rather than just stage this PR's changes. However you get there is fine with me. :)

@alespour alespour marked this pull request as ready for review October 13, 2023 10:44
Copy link
Contributor

@jdstrand jdstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not done chronograf updates before, but looking at prior commits and seeing that chronograf-20231013 is in quay.io, approving.

@jeffreyssmith2nd jeffreyssmith2nd merged commit 75eb219 into master Oct 13, 2023
3 checks passed
@jeffreyssmith2nd jeffreyssmith2nd deleted the chore/go-1.20.10 branch October 13, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants