Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert EmptyState, Tabs, NavMenu, IndexList, and Page families. #328

Merged
merged 6 commits into from
Oct 14, 2019
Merged

Convert EmptyState, Tabs, NavMenu, IndexList, and Page families. #328

merged 6 commits into from
Oct 14, 2019

Conversation

mavarius
Copy link
Collaborator

@mavarius mavarius commented Oct 14, 2019 •
edited

Closes #297
Closes #292
Closes #300
Closes #302
Closes #311

Changes

  • Convert IndexList family to functional components and expose refs
  • [Breaking] Prepend cf- to all IndexList class names
  • Convert EmptyState family to functional components and expose refs
  • [Breaking] Remove text and highlightedText props from EmptyStateText and EmptyStateSubtext components in favor of directly passing children
  • Convert Tabs family to functional components and expose refs
  • Convert NavMenu family to functional components and expose refs
  • Convert IndexList family to functional components and expose refs
  • Convert Page family to functional components and expose refs
  • [Breaking] Export PageHeaderLeft, PageHeaderCenter, and PageHeaderRight directly from Page instead of Page.Header
  • Added Documentation folder

Checklist

  • Updated documentation to reflect changes
  • Added entry to the top of Changelog with link to PR (not the issue)
  • Tests pass
  • Peer-reviewed and approved

@mavarius mavarius changed the title Convert EmptyState, Tabs, NavMenu, Page families. Convert EmptyState, Tabs, NavMenu, IndexList, and Page families. Oct 14, 2019
alexpaxton
alexpaxton approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@alexpaxton alexpaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@mavarius mavarius merged commit 43f011f into master Oct 14, 2019
@alexpaxton alexpaxton mentioned this pull request Oct 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpaxton alexpaxton alexpaxton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mavarius @alexpaxton