Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.194.{3,4} failed to build against rust 1.72.0 #5438

Closed
chenrui333 opened this issue Oct 26, 2023 · 0 comments · Fixed by #5440
Closed

0.194.{3,4} failed to build against rust 1.72.0 #5438

chenrui333 opened this issue Oct 26, 2023 · 0 comments · Fixed by #5440

Comments

@chenrui333
Copy link

While upgrading rust to 1.72.0, we found some build failure with flux 0.194.3 and it is also reproducible with 0.194.4

     Compiling flux-core v0.154.0 (/private/tmp/flux-20231025-5721-1q34rp8/libflux/flux-core)
     Compiling getrandom v0.2.8
     Compiling once_cell v1.17.1
     Compiling flux v0.154.0 (/private/tmp/flux-20231025-5721-1q34rp8/libflux/flux)
  error: private item shadows public glob re-export
    --> flux/src/lib.rs:12:16
     |
  12 | use fluxcore::{Database, Flux};
     |                ^^^^^^^^
     |
  note: the name `Database` in the type namespace is supposed to be publicly re-exported here
    --> flux/src/lib.rs:16:46
     |
  16 | pub use fluxcore::{ast, formatter, semantic, *};
     |                                              ^
  note: but the private item here shadows it
    --> flux/src/lib.rs:12:16
     |
  12 | use fluxcore::{Database, Flux};
     |                ^^^^^^^^
  note: the lint level is defined here
    --> flux/src/lib.rs:1:38
     |
  1  | #![cfg_attr(feature = "strict", deny(warnings, missing_docs))]
     |                                      ^^^^^^^^
     = note: `#[deny(hidden_glob_reexports)]` implied by `#[deny(warnings)]`
  
  error: private item shadows public glob re-export
    --> flux/src/lib.rs:12:26
     |
  12 | use fluxcore::{Database, Flux};
     |                          ^^^^
     |
  note: the name `Flux` in the type namespace is supposed to be publicly re-exported here
    --> flux/src/lib.rs:16:46
     |
  16 | pub use fluxcore::{ast, formatter, semantic, *};
     |                                              ^
  note: but the private item here shadows it
    --> flux/src/lib.rs:12:26
     |
  12 | use fluxcore::{Database, Flux};
     |                          ^^^^
  

relates to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant