-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contrib/qxip): add contrib/qxip/logql package #5353
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmangani
requested review from
nathanielc and
sanderson
and removed request for
a team
December 20, 2022 21:43
lmangani
changed the title
feat(contrib/qxip): add contrib/qxip/clickhouse package
feat(contrib/qxip): add contrib/qxip/logql package
Dec 20, 2022
sanderson
requested changes
Dec 21, 2022
lmangani
force-pushed
the
contrib-logql
branch
from
December 21, 2022 16:00
ae54272
to
26cd3f7
Compare
lmangani
force-pushed
the
contrib-logql
branch
from
December 21, 2022 16:09
772f1b3
to
3470e6c
Compare
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
sanderson
approved these changes
Dec 21, 2022
Thanks @sanderson for the corrections. We're rebased on master now, let us know if anything else is needed for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds contrib/qxip/logql package to interact with LogQL HTTP APIs such as Grafana Loki or qryn.
The contrib adds no go code and only wraps flux functions. Included readme explains the functionality.
Done checklist