Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iox): add iox.sqlInterval to convert flux durations to SQL interval strings #5356

Merged
merged 3 commits into from
Jan 5, 2023

Conversation

sanderson
Copy link
Contributor

@sanderson sanderson commented Jan 5, 2023

This PR updates the iox package with examples and a new iox.sqlnterval function that converts a Flux duration value to a SQL interval string (2d12h -> 2 days 12 hours). This stems from a request to be able to use v.windowPeriod with iox.sql to define window boundaries.


Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

@sanderson sanderson requested review from a team as code owners January 5, 2023 17:43
@sanderson sanderson requested review from nathanielc and lwandzura and removed request for a team January 5, 2023 17:43
@sanderson sanderson merged commit 8c5176f into master Jan 5, 2023
@sanderson sanderson deleted the iox-sql-interval branch January 5, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants