Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor stat memoization #36

Closed
chnn opened this issue May 1, 2019 · 1 comment
Closed

Refactor stat memoization #36

chnn opened this issue May 1, 2019 · 1 comment
Assignees
@chnn
Labels
epic/vis refactor team/ui
Projects
backlog/vis

Comments

@chnn
Copy link
Contributor

chnn commented May 1, 2019 •
edited

Stats should be computed lazily, and recomputed only when necessary. Memoization for a particular stat should be based on its precise dependencies, rather than a hacky guess of its dependencies as we do now:

https://github.com/influxdata/vis/blob/b8638c90878c07f6581bd93292b8b7bdd49b8ce7/src/utils/PlotEnv.ts#L82-L89
@chnn chnn created this issue from a note in backlog/vis (Proposed) May 1, 2019
@chnn chnn added the refactor label May 1, 2019
@chnn chnn moved this from Proposed to Ready in backlog/vis May 1, 2019
@chnn chnn moved this from Ready to In Progress in backlog/vis May 6, 2019
@chnn chnn added the epic/vis label May 10, 2019
@chnn chnn self-assigned this May 10, 2019
@chnn chnn added the team/ui label May 10, 2019
@chnn chnn moved this from In Progress to In Review in backlog/vis May 14, 2019
@chnn
Copy link
Contributor Author

chnn commented May 14, 2019

b1ffe30

@chnn chnn closed this as completed May 14, 2019
backlog/vis automation moved this from In Review to Done May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chnn chnn

Labels
epic/vis refactor team/ui
Projects
No open projects
backlog/vis
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chnn