[telegraf-ds] Add option for simple override of TOML config file contents #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended as a partial fix/workaround for #221; a more complete fix will require waiting for a fix to bugs in Helm itself, which could take some time. This PR provides an "escape hatch" as where the end user can hand-write their own TOML if necessary. This was discussed as an option by @rawkode in a comment on the issue.
To use the escape hatch, set
config_override.tomlto a string containing the full contents of a valid Telegraf config file.The more complete fix is at core waiting on kubernetes-sigs/yaml#45 to be fixed, and then for that fix to make its way into a new release of Helm.