feat: reimplement influx backup using new APIs
#116
Conversation
| return fmt.Errorf("failed to download metadata snapshot: %w", err) | ||
| } | ||
|
|
||
| kvName := fmt.Sprintf("%s.bolt", c.baseName) |
There was a problem hiding this comment.
We are setting a base name on the server as well and including it with the response (https://github.com/influxdata/influxdb/blob/40c7d694154e75103f614cc15fdf329cdb5c0bcc/http/backup_service.go#L163). Looking at the client implementation, I think it's better to set it here though - easier to make sure all the backed up files match.
Unless you need it for something on the client (I don't think so?), at some point we might want to remove setting the filename on the server response, just to keep things from being confusing.
There was a problem hiding this comment.
👍 I think removing it would make sense. I opened an issue to support gzipping the response on the server-side, I'll add a note about dropping the file names there as well.
Closes #6
Closes #113
Tests aren't comprehensive, but I think they cover the most interesting pieces of the logic.