fix: fix type test for common flags #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
commented
Sep 21, 2021
| @@ -15,6 +15,7 @@ This release upgrades the project to `go` version 1.17. | |||
| 1. [232](https://github.com/influxdata/influx-cli/pull/232): Don't set empty strings for IDs in permission resources. | |||
| 1. [236](https://github.com/influxdata/influx-cli/pull/236): Detect and error out on incorrect positional args. | |||
| 1. [255](https://github.com/influxdata/influx-cli/pull/255): Respect value of `--host` flag when writing CLI configs in `setup`. | |||
| 1. [272](https://github.com/influxdata/influx-cli/pull/272): Reduce overuse of "token" in help text. | |||
There was a problem hiding this comment.
Not yet automated in this repo.
Note this is for the PR that changed the help text in the first place, since this PR is just a fixup for the unreleased logic.
lesam
approved these changes
Sep 21, 2021
| @@ -271,9 +271,9 @@ OPTIONS: | |||
| customFunc := make(map[string]interface{}) | |||
| customFunc["iscommon"] = func(flag cli.Flag) bool { | |||
| switch flag.(type) { | |||
| case CommonBoolFlag: | |||
| case *CommonBoolFlag: | |||
There was a problem hiding this comment.
Oops - thanks! Must not have tested the final version after switching to the switch statement :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup for #272