fix(signin): Check for all available cookies instead of the count #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreyssmith2nd
approved these changes
Apr 26, 2023
jeffreyssmith2nd
added a commit
that referenced
this pull request
Apr 26, 2023
* chore: build windows packages on release (#490) * fix: don't attempt to overwrite influxdb installs (#493) (#494) * fix: don't attempt to overwrite influxdb installs * fix: don't attempt to overwrite influxdb installs * fix: rename package to influxdb2-cli (#495) The package filename remains "influxdb2-client"; however, internally the package has been renamed to "influxdb2-cli". This is so upgrades are performed correctly by apt and yum (which use the package metadata rather than the filename). This also swaps out underscores to slashes to match what influxdata-docker expects. * chore: update to go 1.20.3 (#496) * chore: update to go 1.20.3 * chore: update to go 1.20.3 * chore: use remote package signing (#498) * chore: make sure .exe is on windows builds (#500) * chore: make sure .exe is on windows builds * chore: make sure .exe is on windows builds * build(deps): bump golang.org/x/text from 0.3.7 to 0.3.8 (#499) Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.7 to 0.3.8. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.3.7...v0.3.8) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(signin): Check for all available cookies instead of the count (#504) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Brandon Pfeifer <bpfeifer@influxdata.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: iLLeniumStudios <104288623+TheiLLeniumStudios@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
It is possible to have multiple cookies returned on a successful sign-in response, specially when it is running behind a reverse proxy etc. This PR fixes the issue by looking up the cookies that contain
influxdbwithin the name (it works on both OSS and cloud) and using the value of that cookie instead of checking for cookie array size.