Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use idiomatic go style for write channels #154

Merged
merged 6 commits into from Jul 15, 2020

Conversation

andig
Copy link
Contributor

@andig andig commented Jul 15, 2020

Closes #145

  • make signalling channels of type struct

  • use closing of signalling channels instead of sending messages

  • CHANGELOG.md updated

  • Rebased/mergeable

  • Tests pass

  • Sign CLA (if not already signed)

@andig andig changed the title Use idiomatic go style fix: use idiomatic go style for write channels Jul 15, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2020

Codecov Report

Merging #154 into master will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   79.20%   79.12%   -0.09%     
==========================================
  Files          26       26              
  Lines        1784     1777       -7     
==========================================
- Hits         1413     1406       -7     
  Misses        245      245              
  Partials      126      126              
Impacted Files Coverage Δ
api/write.go 93.75% <100.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e978ae...753f79d. Read the comment docs.

@vlastahajek vlastahajek self-requested a review July 15, 2020 18:11
Copy link
Contributor

@vlastahajek vlastahajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@vlastahajek vlastahajek merged commit cf466f3 into influxdata:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce the number of channels used in this library
3 participants