Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: synchronizing access to write service #209

Merged
merged 1 commit into from Oct 30, 2020
Merged

fix: synchronizing access to write service #209

merged 1 commit into from Oct 30, 2020

Conversation

vlastahajek
Copy link
Contributor

Closes #208

Proposed Changes

Synchronizing access to the write.Service in the WriteAPIBlocking.write function to prevent race conditions.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are in semantic format

sranka
sranka approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@sranka sranka left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the fact that I am not a fan of such a top-level synchronization, approved ... assuming there is no better way now.

@vlastahajek vlastahajek merged commit 2068222 into influxdata:master Oct 30, 2020
@vlastahajek vlastahajek deleted the fix/wab_sync branch October 30, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sranka sranka sranka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsynchronized WriteAPIBlocking.Write* functions
2 participants
@vlastahajek @sranka