fix: retain full error information for blocking writes (#293) #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
pabigot
force-pushed
the
pabigot/20211222a
branch
2 times, most recently
from
d0924cc
to
0c248b5
Compare
Codecov Report
@@ Coverage Diff @@
## master #294 +/- ##
==========================================
- Coverage 91.87% 91.77% -0.10%
==========================================
Files 23 23
Lines 2042 2042
==========================================
- Hits 1876 1874 -2
- Misses 110 112 +2
Partials 56 56
Continue to review full report at Codecov.
|
pabigot
force-pushed
the
pabigot/20211222a
branch
from
0c248b5
to
31b43d9
Compare
vlastahajek
reviewed
Jan 3, 2022
vlastahajek
approved these changes
Jan 3, 2022
There was a problem hiding this comment.
@pabigot, thanks for the issue and the fix! Call to Unwrap is really useless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #293
Proposed Changes
Briefly describe your proposed changes:
Checklist