test: add an exported constructor for QueryTableResult #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QueryTableResult is a struct with private unexported fields, so mocking this in external tests when the Influx client is used is difficult. This adds an exported constructor to make external mocking and testing easier.
vlastahajek
approved these changes
Feb 3, 2022
vlastahajek
deleted the
test/add-exported-constructor-for-QueryTableResult
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
| recently added an Influx Integration to another system and it was difficult to mock QueryTableResult so thought I'd make a PR to improve that.
QueryTableResult is a struct with private unexported fields, so
mocking this in external tests when the Influx client is used is
difficult. This adds an exported constructor to make external mocking
and testing easier.
Checklist