Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: write retry delay #335

Merged
merged 4 commits into from Jun 22, 2022
Merged

fix: write retry delay #335

merged 4 commits into from Jun 22, 2022

Commits on Jun 20, 2022

  1. fix: write retry queue forgets accumulated delay when batches are dis… 

    …carded

Design error, RetryDelay should be tracked in the service/queue and not in the batch. Similarly, a service/queue-level RetryAttempts should be used by computeRetryDelay() instead of a batch-level value.
    @seth-hunter
    seth-hunter committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    4720873 View commit details
    Browse the repository at this point in the history

  2. style: move min() function from write/service.go to write/service_tes… 

    …t.go

min() function isn't used in service.go, only in service_test.go
    @seth-hunter
    seth-hunter committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    42d6592 View commit details
    Browse the repository at this point in the history

  3. test: add write queue retry delay accumulation test

    @seth-hunter
    seth-hunter committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    29369c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. refactor: make new write/service.go state variables private rather th… 

    …an public
    @seth-hunter
    seth-hunter committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    337ba61 View commit details
    Browse the repository at this point in the history