Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): allow to overwrite default write API HTTP path #449

Merged
merged 3 commits into from
May 24, 2022

Conversation

sranka
Copy link
Contributor

@sranka sranka commented May 23, 2022

This PR allows changing the default HTTP path of InfluxDB write API service so that any endpoint that accepts InfluxDB line protocol data can be used:

  const writeAPI = new InfluxDB({url, token}).getWriteApi(org, bucket, precision)
  writeAPI.httpPath = '/api/v1/influxdb/write'

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • yarn test completes successfully
  • Commit messages are conventional

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022

Codecov Report

Merging #449 (42f42dc) into master (7a69f83) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #449   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           33        33           
  Lines         1234      1234           
  Branches       292       292           
=========================================
  Hits          1234      1234           
Impacted Files Coverage Δ
packages/core/src/impl/WriteApiImpl.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a69f83...42f42dc. Read the comment docs.

@sranka sranka requested review from vlastahajek and bednar May 23, 2022 13:02
@sranka sranka marked this pull request as ready for review May 23, 2022 20:06
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sranka sranka merged commit 3395560 into master May 24, 2022
@sranka sranka deleted the feat/custom_write_http_path branch May 24, 2022 08:14
@bednar bednar added this to the 1.27.0 milestone Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants