Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: client could be configured via TOML file #203

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Mar 11, 2021

Closes #201

Proposed Changes

Allow configuring client via TOML file - InfluxDB 2 config file.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #203 (b0c5df5) into master (4f1e14e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   89.93%   89.94%   +0.01%     
==========================================
  Files          26       26              
  Lines        1967     1970       +3     
==========================================
+ Hits         1769     1772       +3     
  Misses        198      198              
Impacted Files Coverage Δ
influxdb_client/client/influxdb_client.py 98.48% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f1e14e...b0c5df5. Read the comment docs.

@bednar bednar requested a review from rhajek March 11, 2021 07:18
@bednar bednar marked this pull request as ready for review March 11, 2021 07:19
@bednar bednar merged commit 8568097 into master Mar 11, 2021
@bednar bednar deleted the feat/configure-via-toml branch March 11, 2021 11:07
@bednar bednar added this to the 1.16.0 milestone Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InfluxDBClient.from_config_file() incompatible with config files generated by influx setup
2 participants