Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Org parameter can be specified as ID, Name or Organization Object #264

Merged
merged 3 commits into from
Jun 10, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jun 7, 2021

Closes #240

Proposed Changes

The org parameter can be specified as ID, Name or Organization. If API requires the ID of Organization then this id is leverage via organization_api.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar requested a review from rhajek June 7, 2021 10:20
@bednar bednar marked this pull request as ready for review June 7, 2021 10:20
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2021

Codecov Report

Merging #264 (e540d3f) into master (0c1d1d9) will increase coverage by 0.07%.
The diff coverage is 96.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   92.52%   92.59%   +0.07%     
==========================================
  Files          25       26       +1     
  Lines        2126     2147      +21     
==========================================
+ Hits         1967     1988      +21     
  Misses        159      159              
Impacted Files Coverage Δ
influxdb_client/client/bucket_api.py 93.93% <75.00%> (-2.62%) ⬇️
influxdb_client/client/query_api.py 99.08% <100.00%> (-0.02%) ⬇️
influxdb_client/client/util/helpers.py 100.00% <100.00%> (ø)
influxdb_client/client/write_api.py 99.06% <100.00%> (ø)
influxdb_client/client/organizations_api.py 89.47% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c1d1d9...e540d3f. Read the comment docs.

@bednar bednar mentioned this pull request Jun 7, 2021
@bednar bednar merged commit 856cca4 into master Jun 10, 2021
@bednar bednar deleted the feature/id-name-organization branch June 10, 2021 06:44
@bednar bednar added this to the 1.19.0 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with bucket example?
3 participants