Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PingService to check status of OSS and Cloud instance #352

Merged
merged 3 commits into from
Oct 22, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Oct 21, 2021

Closes #211

Proposed Changes

  • Added PingService to check status of OSS and Cloud instance.
  • Deprecates: InfluxDBClient.health(): instead use InfluxDBClient.ping()

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar requested a review from rhajek October 21, 2021 09:42
@bednar bednar marked this pull request as ready for review October 21, 2021 09:42
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2021

Codecov Report

Merging #352 (c0cf6e4) into master (d284254) will increase coverage by 0.06%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   92.74%   92.81%   +0.06%     
==========================================
  Files          27       27              
  Lines        2275     2297      +22     
==========================================
+ Hits         2110     2132      +22     
  Misses        165      165              
Impacted Files Coverage Δ
influxdb_client/client/influxdb_client.py 97.77% <95.00%> (-0.36%) ⬇️
influxdb_client/__init__.py 100.00% <100.00%> (ø)
influxdb_client/client/__init__.py 100.00% <100.00%> (ø)
influxdb_client/client/write/__init__.py 100.00% <100.00%> (ø)
influxdb_client/api_client.py 69.28% <0.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d284254...c0cf6e4. Read the comment docs.

@bednar bednar merged commit 5834332 into master Oct 22, 2021
@bednar bednar deleted the feat/ping branch October 22, 2021 07:27
@bednar bednar added this to the 1.23.0 milestone Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

health check not working
3 participants