Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: numpy no longer supports np.float type #543

Merged
merged 1 commit into from
Dec 27, 2022
Merged

fix: numpy no longer supports np.float type #543

merged 1 commit into from
Dec 27, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Dec 21, 2022

Proposed Changes

The numpy no longer supports np.float type:

image

For more info see - https://numpy.org/doc/stable/release/1.24.0-notes.html

This PR also fixes CI builds:

image

image

https://app.circleci.com/pipelines/github/influxdata/influxdb-client-python?branch=clarify-config-measurements

Checklist

  • Rebased/mergeable
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review December 21, 2022 08:51
@codecov-commenter
Copy link

Codecov Report

Base: 90.36% // Head: 90.36% // No change to project coverage 👍

Coverage data is based on head (b9dbdc0) compared to base (03f5bd7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #543   +/-   ##
=======================================
  Coverage   90.36%   90.36%           
=======================================
  Files          39       39           
  Lines        3437     3437           
=======================================
  Hits         3106     3106           
  Misses        331      331           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bednar bednar requested a review from powersj December 27, 2022 09:43
@bednar bednar merged commit df12e0b into master Dec 27, 2022
@bednar bednar deleted the numpy-float branch December 27, 2022 09:44
@bednar bednar added this to the 1.35.0 milestone Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants