Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logging for HTTP requests #106

Merged
merged 8 commits into from
Jul 15, 2022
Merged

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jul 7, 2022

Proposed Changes

  1. Added logging for HTTP requests
  2. Redacted Authorization HTTP header from log

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • rake test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review July 7, 2022 04:26
@bednar bednar requested a review from rhajek July 7, 2022 04:26
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #106 (e0d82d1) into master (3910378) will increase coverage by 1.20%.
The diff coverage is 82.60%.

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   49.86%   51.07%   +1.20%     
==========================================
  Files          64       65       +1     
  Lines        6495     6349     -146     
==========================================
+ Hits         3239     3243       +4     
+ Misses       3256     3106     -150     
Impacted Files Coverage Δ
...influxdb2/apis/generated/api/authorizations_api.rb 49.01% <ø> (+4.75%) ⬆️
...is/lib/influxdb2/apis/generated/api/buckets_api.rb 24.75% <ø> (+2.95%) ⬆️
...pis/lib/influxdb2/apis/generated/api/labels_api.rb 46.93% <ø> (+4.56%) ⬆️
.../influxdb2/apis/generated/api/organizations_api.rb 49.12% <ø> (+4.26%) ⬆️
apis/lib/influxdb2/apis/generated/api/users_api.rb 34.25% <ø> (+3.83%) ⬆️
apis/lib/influxdb2/apis/generated/api_client.rb 63.52% <54.54%> (-0.28%) ⬇️
lib/influxdb2/client/default_api.rb 97.01% <71.42%> (-1.52%) ⬇️
lib/influxdb2/client/utils/logging_helper.rb 95.83% <95.83%> (ø)
apis/lib/influxdb2/apis/api.rb 100.00% <100.00%> (ø)
lib/influxdb-client.rb 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3910378...e0d82d1. Read the comment docs.

@bednar bednar merged commit 0da0307 into master Jul 15, 2022
@bednar bednar deleted the authorization-header-redacted branch July 15, 2022 07:27
@bednar bednar added this to the 2.7.0 milestone Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants