Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add max_retries, max_retry_delay and exponential_base to WriteApi #47

Merged
merged 10 commits into from
Aug 13, 2020

Conversation

rolincova
Copy link
Contributor

Closes

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • rake test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2020

Codecov Report

Merging #47 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   99.31%   99.34%   +0.02%     
==========================================
  Files          12       12              
  Lines         588      610      +22     
==========================================
+ Hits          584      606      +22     
  Misses          4        4              
Impacted Files Coverage Δ
lib/influxdb2/client/default_api.rb 100.00% <100.00%> (ø)
lib/influxdb2/client/influx_error.rb 100.00% <100.00%> (ø)
lib/influxdb2/client/worker.rb 93.44% <100.00%> (+0.71%) ⬆️
lib/influxdb2/client/write_api.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab10a33...281ce2b. Read the comment docs.

@rolincova rolincova changed the title Feat: Add max_retries and max_retry_delay to WriteApi feat: Add max_retries and max_retry_delay to WriteApi Aug 5, 2020
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The retry strategy should also work for connection errors (i.e: restarting server, reloading SSL certificate).

The active_merchant has similar strategy:

https://github.com/activemerchant/active_merchant/blob/0b28ca3f575fc77420605197bf7d078f460f26d8/lib/active_merchant/network_connection_retries.rb#L6

@rolincova rolincova changed the title feat: Add max_retries and max_retry_delay to WriteApi feat: Add max_retries, max_retry_delay and exponential_base to WriteApi Aug 12, 2020
lib/influxdb2/client/influx_error.rb Outdated Show resolved Hide resolved
lib/influxdb2/client/influx_error.rb Outdated Show resolved Hide resolved
lib/influxdb2/client/influx_error.rb Outdated Show resolved Hide resolved
lib/influxdb2/client/influx_error.rb Outdated Show resolved Hide resolved
lib/influxdb2/client/influx_error.rb Outdated Show resolved Hide resolved
lib/influxdb2/client/influx_error.rb Outdated Show resolved Hide resolved
lib/influxdb2/client/default_api.rb Outdated Show resolved Hide resolved
lib/influxdb2/client/worker.rb Outdated Show resolved Hide resolved
@bednar bednar merged commit d3dfbaf into master Aug 13, 2020
@bednar bednar deleted the feat/retry-strategy branch August 13, 2020 08:14
@bednar bednar added this to the 1.7.0 milestone Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants