Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Authorization header is not forwarded when redirect leads to a different domain #89

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Aug 23, 2021

Proposed Changes

  1. Authorization header is not forwarded when redirect leads to a different domain
  2. Fix redirect location
  3. Add documentation how to configure proxy

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • rake test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

Codecov Report

Merging #89 (fd1d882) into master (346f213) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head fd1d882 differs from pull request most recent head 86e5077. Consider uploading reports for the commit 86e5077 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   98.98%   98.99%           
=======================================
  Files          16       16           
  Lines         788      793    +5     
=======================================
+ Hits          780      785    +5     
  Misses          8        8           
Impacted Files Coverage Δ
lib/influxdb2/client/client.rb 100.00% <ø> (ø)
lib/influxdb2/client/default_api.rb 98.55% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 346f213...86e5077. Read the comment docs.

@bednar bednar marked this pull request as ready for review August 23, 2021 10:54
@bednar bednar requested a review from rhajek August 23, 2021 10:54
@bednar bednar merged commit c9a3f0a into master Aug 31, 2021
@bednar bednar deleted the feat/redirect-authorization branch August 31, 2021 08:52
@bednar bednar added this to the 1.18.0 milestone Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants