Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add parameterized queries #96

Merged
merged 20 commits into from
Jan 31, 2022
Merged

feat: add parameterized queries #96

merged 20 commits into from
Jan 31, 2022

Conversation

michaelahojna
Copy link
Contributor

@michaelahojna michaelahojna commented Jan 26, 2022 •
edited

Closes #

Proposed Changes

Add parameterized queries with example

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • rake test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@michaelahojna michaelahojna marked this pull request as ready for review January 27, 2022 10:39
bednar
bednar requested changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍
There are a few requirements that must be be satisfy before we accept the PR:

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
examples/parameterized_query.rb Outdated Show resolved Hide resolved
lib/influxdb2/client/query_api.rb Show resolved Hide resolved
lib/influxdb2/client/query_api.rb Show resolved Hide resolved
lib/influxdb2/client/query_api.rb Show resolved Hide resolved
test/influxdb/query_api_test.rb Show resolved Hide resolved
test/influxdb/query_api_test.rb Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2022 •
edited

Codecov Report

Merging #96 (39caccf) into master (33873c3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   98.67%   98.68%           
=======================================
  Files          17       17           
  Lines         833      834    +1     
=======================================
+ Hits          822      823    +1     
  Misses         11       11
Impacted Files Coverage Δ
lib/influxdb2/client/query_api.rb 94.73% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33873c3...39caccf. Read the comment docs.

bednar
bednar approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@michaelahojna michaelahojna merged commit ae07a4a into master Jan 31, 2022
@michaelahojna michaelahojna deleted the query_parameters branch January 31, 2022 13:02
@bednar bednar added this to the 2.2.0 milestone Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar bednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michaelahojna @codecov-commenter @bednar