Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Async examples #55

Merged
merged 23 commits into from Sep 15, 2022
Merged

docs: Async examples #55

merged 23 commits into from Sep 15, 2022

Conversation

michaelahojna
Copy link
Contributor

@michaelahojna michaelahojna commented Sep 14, 2022

Closes #54

Edit examples to async

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • swift test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@michaelahojna michaelahojna changed the title Async examples docs: Async examples Sep 14, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 49.07% // Head: 65.25% // Increases project coverage by +16.17% 🎉

Coverage data is based on head (a38662a) compared to base (a8ce9a2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #55       +/-   ##
===========================================
+ Coverage   49.07%   65.25%   +16.17%     
===========================================
  Files         145       17      -128     
  Lines        9017     1321     -7696     
===========================================
- Hits         4425      862     -3563     
+ Misses       4592      459     -4133     
Impacted Files Coverage Δ
Sources/InfluxDBSwift/DeleteAPI.swift 79.72% <ø> (ø)
Sources/InfluxDBSwift/QueryAPI.swift 64.42% <ø> (ø)
Sources/InfluxDBSwift/WriteAPI.swift 61.09% <ø> (ø)
...uxDBSwiftTests/AAJunitReportInitializerTests.swift
...nfluxDBSwiftApis/Generated/Models/DBRPUpdate.swift
...InfluxDBSwiftApis/Generated/Models/TaskLinks.swift
Tests/InfluxDBSwiftApisTests/ReadyAPITests.swift
Tests/InfluxDBSwiftApisTests/DBRPsAPITests.swift
...is/Generated/Models/AuthorizationPostRequest.swift
Tests/InfluxDBSwiftTests/QueryAPITests.swift
... and 121 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bednar bednar self-requested a review September 15, 2022 07:16
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍

Please migrate the Query to Data example to async/await too:

image

@michaelahojna michaelahojna marked this pull request as ready for review September 15, 2022 08:40
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bednar bednar merged commit 4e723a9 into master Sep 15, 2022
@bednar bednar deleted the async_examples branch September 15, 2022 09:14
@bednar bednar added this to the 1.4.0 milestone Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

async/await update to Swift API
3 participants