feat(jaeger-influxdb): forgive and handle schema://host:port #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This affects flag --influxdb-addr / env var INFLUXDB_ADDR. Because the demo requires an HTTP URL for write (otelcol), and a gRPC host:port for query (jaeger-influxdb), let's be flexible with the jaeger-influxdb constraints by allowing prefixes http://, https://, grpc://, grpc+tcp://, grpc+tls://. Accepting the HTTP prefixes is "forgiving". Accepting the gRPC prefixes is treated as "normal" handling, just like host:port. I've added unit tests this time. :) Also, tested with the Docker Compose demo.
jacobmarble
force-pushed
the
jgm-jaeger-influxdb-addr-parse
branch
from
9d75dd9
to
f0e0b8e
Compare
philjb
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects flag --influxdb-addr / env var INFLUXDB_ADDR. Because the demo requires an HTTP URL for write (otelcol), and a gRPC host:port for query (jaeger-influxdb), let's be flexible with the jaeger-influxdb constraints by allowing prefixes http://, https://, grpc://, grpc+tcp://, grpc+tls://.
Accepting the HTTP prefixes is "forgiving". Accepting the gRPC prefixes is treated as "normal" handling, just like host:port.
I've added unit tests this time. :) Also, tested with the Docker Compose demo.