Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Fix example server_data to support v0.9 #115

Merged
merged 4 commits into from Mar 11, 2015

Conversation

areski
Copy link
Contributor

@areski areski commented Mar 7, 2015

This includes fixes for the private method '_query' from client.py to work
properly with influxdb v0.9 API

This includes fixes for the private method '_query' from client.py to work
properly with influxdb v0.9 API
@aviau
Copy link
Collaborator

aviau commented Mar 9, 2015

_query is no longer used. Changes should be made in the query method instead. I had not removed _query yet but we had talked about it in #113

@aviau
Copy link
Collaborator

aviau commented Mar 9, 2015

Keep in mind that you can no longer query with a specific precision:

The format of the returned timestamps complies with RFC3339, and has nanosecond precision.

@areski
Copy link
Contributor Author

areski commented Mar 10, 2015

I like the idea of not having to set database all the time, maybe we should open a new ticket to follow up on this.

@areski
Copy link
Contributor Author

areski commented Mar 10, 2015

See last commit, it removes the query method and make query method compliant with dataframe_client

@@ -276,6 +297,7 @@ def _write_points(self,
if self.use_udp:
self.send_packet(data)
else:
import ipdb; ipdb.set_trace()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@areski oops!

@areski
Copy link
Contributor Author

areski commented Mar 10, 2015

I often have the bad habbits to count on travis-ci to run the tests :)
debugging removed! thanks

@@ -195,21 +195,40 @@ def query(self,
query,
params={},
expected_response_code=200,
time_precision='s',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no time precision in queries.

see: http://influxdb.com/docs/v0.9/concepts/reading_and_writing_data.html

The format of the returned timestamps complies with RFC3339, and has nanosecond precision

@aviau
Copy link
Collaborator

aviau commented Mar 10, 2015

I'll take care of it.

@areski
Copy link
Contributor Author

areski commented Mar 11, 2015

Ok I'm leaving this to you

@aviau aviau merged commit 4654015 into influxdata:0.9.0_support Mar 11, 2015
@aviau
Copy link
Collaborator

aviau commented Mar 11, 2015

@areski Thanks =)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants