This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
Fix failing tags match in get_points() on a ResultSet #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the format of the object in the ResultSet test to match what's returned from a query fix other flake8 formatting issues
|
fixing CI now, i omitted server tests from my testing. |
|
Can you explain this to me a little? Does that mean that tags no longer exist in influxdb? They are now returned as columns? |
|
Looking at the API on the influxdb website, this looks good to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #506.
Most of this diff is renaming or reformatting, the only real logical change is at line 108 where I flipped the if & for statements, and passed the tags into _tag_matches rather than passing an empty dict.