Skip to content

Commit

Permalink
TSI byte copy usage comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
benbjohnson committed Oct 18, 2017
1 parent d17d0f1 commit 8ad2048
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions tsdb/index/tsi1/index.go
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,8 @@ func (i *Index) MeasurementNamesByExpr(expr influxql.Expr) ([][]byte, error) {
defer fs.Release()

names, err := fs.MeasurementNamesByExpr(expr)

// Clone byte slices since they will be used after the fileset is released.
return bytesutil.CloneSlice(names), err
}

Expand All @@ -416,6 +418,7 @@ func (i *Index) MeasurementNamesByRegex(re *regexp.Regexp) ([][]byte, error) {
var a [][]byte
for e := itr.Next(); e != nil; e = itr.Next() {
if re.Match(e.Name()) {
// Clone bytes since they will be used after the fileset is released.
a = append(a, bytesutil.Clone(e.Name()))
}
}
Expand Down Expand Up @@ -731,6 +734,8 @@ func (i *Index) MeasurementSeriesKeysByExpr(name []byte, expr influxql.Expr) ([]
defer fs.Release()

keys, err := fs.MeasurementSeriesKeysByExpr(name, expr, i.fieldset)

// Clone byte slices since they will be used after the fileset is released.
return bytesutil.CloneSlice(keys), err
}

Expand Down

0 comments on commit 8ad2048

Please sign in to comment.