Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x,2.x] Shard deletion handles errors incorrectly [port to main-2.x] #24836

Closed
davidby-influx opened this issue Mar 25, 2024 · 0 comments · Fixed by #24844
Closed

[1.x,2.x] Shard deletion handles errors incorrectly [port to main-2.x] #24836

davidby-influx opened this issue Mar 25, 2024 · 0 comments · Fixed by #24844
Assignees
@davidby-influx
Labels
area/tsm area/2.x OSS 2.0 related issues and PRs kind/bug team/edge

Comments

@davidby-influx
Copy link
Contributor

port #24834 to main-2.x
@davidby-influx davidby-influx self-assigned this Mar 25, 2024
@davidby-influx davidby-influx changed the title [1.x,2.x] Shard deletion handles errors incorrectly [port to main=2.x] [1.x,2.x] Shard deletion handles errors incorrectly [port to main-2.x] Mar 25, 2024
@davidby-influx davidby-influx mentioned this issue Mar 25, 2024
Closed
davidby-influx added a commit that referenced this issue Mar 26, 2024
@davidby-influx
fix: improved shard deletion (#24602)
2e19001 
Avoid unnecessarily deleting series from the series file
Try harder to delete series from InMem indices
Log all errors on shard deletion

Closes #24834

(cherry picked from commit 8ff06d5)

closes #24836
@davidby-influx davidby-influx mentioned this issue Mar 26, 2024
Merged
davidby-influx added a commit that referenced this issue Mar 26, 2024
@davidby-influx
fix: return and respect cursor errors (#24791)
2f7b56b 
ArrayCursors were ignoring errors, which led to panics when nil
cursors were operated on. This fix passes errors back up the stack
and uses them to enforce healthy cursor creation.

Closes #24789
---------
Co-authored-by: Stuart Carnie <stuart.carnie@gmail.com>

(cherry picked from commit fe6c64b)

closes #24836
@davidby-influx davidby-influx mentioned this issue Mar 26, 2024
Merged
@davidby-influx davidby-influx linked a pull request Mar 26, 2024 that will close this issue
fix: return and respect cursor errors (#24791) #24846
Merged
@davidby-influx davidby-influx removed a link to a pull request Mar 26, 2024
fix: return and respect cursor errors (#24791) #24846
Merged
@davidby-influx davidby-influx linked a pull request Mar 26, 2024 that will close this issue
fix: improved shard deletion (#24602) #24844
Merged
davidby-influx added a commit that referenced this issue Mar 26, 2024
@davidby-influx
fix: improved shard deletion (#24602) (#24844)
2066c4b 
Avoid unnecessarily deleting series from the series file
Log all errors on shard deletion

Closes #24834

(cherry picked from commit 8ff06d5)

closes #24836
davidby-influx added a commit that referenced this issue Mar 26, 2024
@davidby-influx
fix: return and respect cursor errors (#24791) (#24846)
49d0bef 
ArrayCursors were ignoring errors, which led to panics when nil
cursors were operated on. This fix passes errors back up the stack
and uses them to enforce healthy cursor creation.

Closes #24789
---------
Co-authored-by: Stuart Carnie <stuart.carnie@gmail.com>

(cherry picked from commit fe6c64b)

closes #24836
davidby-influx added a commit that referenced this issue Mar 27, 2024
@davidby-influx
fix: return and respect cursor errors (#24791) (#24846)
e290d7a 
ArrayCursors were ignoring errors, which led to panics when nil
cursors were operated on. This fix passes errors back up the stack
and uses them to enforce healthy cursor creation.

Closes #24789
---------
Co-authored-by: Stuart Carnie <stuart.carnie@gmail.com>

(cherry picked from commit fe6c64b)

closes #24836

(cherry picked from commit 49d0bef)

closes #24826
@davidby-influx davidby-influx mentioned this issue Mar 27, 2024
Merged
davidby-influx added a commit that referenced this issue Mar 27, 2024
@davidby-influx
fix: improved shard deletion (#24602) (#24844)
308dea7 
Avoid unnecessarily deleting series from the series file
Log all errors on shard deletion

Closes #24834

(cherry picked from commit 8ff06d5)

closes #24836

(cherry picked from commit 2066c4b)

closes #24837
@davidby-influx davidby-influx mentioned this issue Mar 27, 2024
Merged
davidby-influx added a commit that referenced this issue Mar 27, 2024
@davidby-influx
fix: improved shard deletion (#24602) (#24844) (#24848)
d2af577 
Avoid unnecessarily deleting series from the series file
Log all errors on shard deletion

Closes #24834

(cherry picked from commit 8ff06d5)

closes #24836

(cherry picked from commit 2066c4b)

closes #24837
davidby-influx added a commit that referenced this issue Mar 27, 2024
@davidby-influx
fix: return and respect cursor errors (#24791) (#24846) (#24847)
8f09e36 
ArrayCursors were ignoring errors, which led to panics when nil
cursors were operated on. This fix passes errors back up the stack
and uses them to enforce healthy cursor creation.

Closes #24789
---------
Co-authored-by: Stuart Carnie <stuart.carnie@gmail.com>

(cherry picked from commit fe6c64b)

closes #24836

(cherry picked from commit 49d0bef)

closes #24826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidby-influx davidby-influx

Labels
area/tsm area/2.x OSS 2.0 related issues and PRs kind/bug team/edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improved shard deletion (#24602) influxdata/influxdb
1 participant
@davidby-influx