Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.9.2] Sending a large number of tag causes panic #3511

Closed
desa opened this issue Jul 30, 2015 · 3 comments
Closed

[0.9.2] Sending a large number of tag causes panic #3511

desa opened this issue Jul 30, 2015 · 3 comments
Assignees
@jwilder

Comments

@desa
Copy link
Contributor

desa commented Jul 30, 2015 

015/07/29 18:39:44 http: panic serving 127.0.0.1:63422: runtime error: index out of range
goroutine 1010 [running]:
net/http.func·011()
    /usr/local/Cellar/go/1.4.2/libexec/src/net/http/server.go:1130 +0xbb
github.com/influxdb/influxdb/tsdb.scanKey(0xc215dbe000, 0xb11, 0xfffe00, 0xaf3, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
    /Users/michaeldesa/go/src/github.com/influxdb/influxdb/tsdb/points.go:276 +0x1350
github.com/influxdb/influxdb/tsdb.parsePoint(0xc215dbe000, 0xb11, 0xfffe00, 0xecd4b7760, 0x17f767e7, 0xab0dc0, 0x6d6db0, 0x1, 0x0, 0x0, ...)
    /Users/michaeldesa/go/src/github.com/influxdb/influxdb/tsdb/points.go:141 +0x86
github.com/influxdb/influxdb/tsdb.ParsePointsWithPrecision(0xc215dbe000, 0xd84730, 0xfffe00, 0xecd4b7760, 0x17f767e7, 0xab0dc0, 0x6d6db0, 0x1, 0x0, 0x0, ...)
    /Users/michaeldesa/go/src/github.com/influxdb/influxdb/tsdb/points.go:124 +0x22a
github.com/influxdb/influxdb/services/httpd.(*Handler).serveWriteLine(0xc2080102a0, 0x245dd40, 0xc20f0e28e0, 0xc20cdd2000, 0xc215dbe000, 0xd84730, 0xfffe00, 0x0)
@desa
Copy link
Contributor Author

desa commented Jul 30, 2015

@toddboom to recreate the issue set

[series]
tag_keys = 100
tag_vals = 1

in the stress script toml file.

Everything is fine if tag_keys<100.

@desa
Copy link
Contributor Author

desa commented Jul 30, 2015

Found the problem. If you up this value then everything works.

@toddboom
Copy link
Contributor

Super lame. Nice catch, btw. This should definitely be handled better.

@jwilder jwilder mentioned this issue Aug 5, 2015
Merged
@jwilder jwilder assigned jwilder and unassigned toddboom Aug 5, 2015
jwilder added a commit that referenced this issue Aug 5, 2015
@jwilder
Fix panic parsing measurement with large number of tags
56d9622 
Defaults to handling measurements with up to 100 tags and will
now grow the slice if there are more instead of panicing.

Fixes #3511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwilder jwilder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@toddboom @jwilder @desa